reference-list: Expand includes #49168
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This uses the same method as sln-add |
Forgind
reviewed
Jun 6, 2025
| @@ -44,7 +44,7 @@ public override int Execute() | |||
| Reporter.Output.WriteLine(new string('-', CliStrings.ProjectReferenceOneOrMore.Length)); | |||
| foreach (var p2p in p2ps) | |||
| { | |||
| Reporter.Output.WriteLine(p2p.Include); | |||
| Reporter.Output.WriteLine(p2p.EvaluatedInclude); | |||
There was a problem hiding this comment.
I don't think the Project is really evaluated at this point; it looks like it just loaded the XML. You might have to call msbuildProj.GetEvaluatedProject() to get a real Project, from which you can call GetItems("ProjectReference") and iterate through that instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49127
Currently, the command lists references without evaluating them, resulting in MSBuild syntax showing up in the command result.
This attempts to fix that.