[RuntimeInteference.targets] add property to opt out of R2R error message #48624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sage Context: dotnet@d21e6bf Context: dotnet/android#10062 We have experimental support for CoreCLR+R2R on Android. Android is also unique in that a default build can target multiple RIDs via: <RuntimeIdentifiers>android-arm;android-arm64;android-x86;android-x64</RuntimeIdentifiers> Unfortunately, targeting 4 RIDs like this results in: dotnet/sdk/10.0.100-preview.4.25180.3/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.RuntimeIdentifierInference.targets(219,5): error NETSDK1191: A runtime identifier for the property 'PublishReadyToRun' couldn't be inferred. Specify a rid explicitly But simply skipping this error message allows the build to succeed, and R2R successfully runs on all 4 RIDs. Just like in d21e6bf, I introduced a new `$(AllowReadyToRunWithoutRuntimeIdentifier)` property to opt out of this error message. I also added `$(AllowPublishSingleFileWithoutRuntimeIdentifier)`, to give the same flexibility in the future.
ghost
added
rolfbjarne
approved these changes
Apr 22, 2025
ivanpovazan
approved these changes
Apr 22, 2025
dsplaisted
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #36047
Context: dotnet/android#10062
We have experimental support for CoreCLR+R2R on Android. Android is also unique in that a default build can target multiple RIDs via:
Unfortunately, targeting 4 RIDs like this results in:
But simply skipping this error message allows the build to succeed, and R2R successfully runs on all 4 RIDs.
Just like in #36047, I introduced a new
$(AllowReadyToRunWithoutRuntimeIdentifier)property to opt out of this error message.I also added
$(AllowPublishSingleFileWithoutRuntimeIdentifier), to give the same flexibility in the future.