-
Notifications
You must be signed in to change notification settings - Fork 281
Add benchmark for ImmutableArrayExtensions #4915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
src/benchmarks/micro/libraries/System.Linq/ImmutableArrayExtensions.cs
Outdated
Show resolved
Hide resolved
src/benchmarks/micro/libraries/System.Linq/ImmutableArrayExtensions.cs
Outdated
Show resolved
Hide resolved
…sions.cs Agreed, adding it. Co-authored-by: xtqqczze <[email protected]>
…sions.cs Co-authored-by: xtqqczze <[email protected]>
File name changed from |
How long does a single operation end up taking? We just want to make sure that we are not in the low nanosecond range. |
The results themselves are the same as those listed in dotnet/runtime#118932.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prozolic I don’t have enough familiarity with this repository to provide a proper review.
I will take a look at this today. |
I think it would sense to get this in before dotnet/runtime#118932 so we can properly validate the new implementation. |
Performance benchmark for
ImmutableArrayExtensions.SequenceEqual
method (related to dotnet/runtime#118932).I have created a new ImmutableArrayExtensions class and added one benchmark. While there are other extension methods for ImmutableArrayExtensions, this implementation focuses only on
ImmutableArrayExtensions.SequenceEqual
.