Performance | Use lower-allocation AE primitives in SqlColumnEncryptionCertificateStoreProvider #3660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypair Also remove an indentation level and dispose of the intermediary X509Certificate2.
This changes some of the test behaviour: previously, it was calling RSADecrypt and RSAVerifySignature directly. Since these methods no longer exist, we follow the public API (which also calls these methods' equivalent functionality.) This also addresses a TODO: in the test code.
Also ensure that the ref structs implement IDisposable.
paulmedynski
requested changes
Oct 6, 2025
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/CoreCryptoTests.cs
Outdated
Show resolved
Hide resolved
...t.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlColumnEncryptionCertificateStoreProvider.cs
Show resolved
Hide resolved
...t.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlColumnEncryptionCertificateStoreProvider.cs
Outdated
Show resolved
Hide resolved
...t.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlColumnEncryptionCertificateStoreProvider.cs
Show resolved
Hide resolved
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Swap Debug.Assert to xUnit assertions. Add explanatory comment when parsing master key path. Remove redundant else.
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
mdaigle
reviewed
Oct 16, 2025
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/CoreCryptoTests.cs
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3660 +/- ##
==========================================
- Coverage 77.23% 0 -77.24%
==========================================
Files 271 0 -271
Lines 45245 0 -45245
==========================================
- Hits 34944 0 -34944
+ Misses 10301 0 -10301
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mdaigle
approved these changes
Oct 17, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is my final PR in this set of changes to this area, picking up where #3612 left off. Benchmarks for this PR are located in #3554.
The previous PR used the AlwaysEncrypted primitives in
SqlColumnEncryptionCspProviderandSqlColumnEncryptionCngProvider. This one introduces them toSqlColumnEncryptionCertificateStoreProvider.While verifying this, I also noticed that the
TestRsaCryptoWithNativeBaselinetest was calling private methods using reflection, but that there was a TODO item in the test to use the public API surface instead. I've done this.Issues
PR 1/3: #3554.
PR 2/3: #3612.
PR 3/3: this one.
Testing
As in the previous PR, automated tests pass. I also created an AE-enabled table in SSMS which used a certificate store-based master key and confirmed that I was able to query it and insert records into it.