-
Notifications
You must be signed in to change notification settings - Fork 0
[EPIC-6378] Prepare/restructure for stable RC #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… sync across Java/Python/C wrappers
Add snippets for nodejs wrapper
… commens and separated functions
…s for scanner/result/etc.
examples/c/src/snippets/datacapture/medical_certificate_scanner.c
Outdated
Show resolved
Hide resolved
examples/java/src/main/java/io/scanbot/sdk/snippets/barcode/DetectBarcodesSnippet.java
Outdated
Show resolved
Hide resolved
examples/java/src/main/java/io/scanbot/sdk/snippets/barcode/DetectBarcodesSnippet.java
Show resolved
Hide resolved
examples/java/src/main/java/io/scanbot/sdk/snippets/barcode/DetectBarcodesSnippet.java
Show resolved
Hide resolved
examples/java/src/main/java/io/scanbot/sdk/snippets/datacapture/CheckScannerSnippet.java
Show resolved
Hide resolved
examples/java/src/main/java/io/scanbot/sdk/snippets/datacapture/CreditCardScannerSnippet.java
Show resolved
Hide resolved
examples/java/src/main/java/io/scanbot/sdk/snippets/license/FloatingLicenseSnippet.java
Outdated
Show resolved
Hide resolved
examples/java/src/main/java/io/scanbot/sdk/snippets/license/FloatingLicenseSnippet.java
Outdated
Show resolved
Hide resolved
examples/python/minimal/snippets/barcode/barcode_document_parser.py
Outdated
Show resolved
Hide resolved
examples/python/minimal/snippets/document/analyse_multi_page.py
Outdated
Show resolved
Hide resolved
examples/nodejs/src/snippets/datacapture/text-pattern-scanner.ts
Outdated
Show resolved
Hide resolved
} | ||
|
||
// TODO Add your SCANBOTSDK_API_TOKEN and SCANBOTSDK_VERSION here. | ||
// They are available on request via [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are available on request via [email protected]
Probably no need to remove this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed [email protected] in all places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should keep them in all the places? It was added initially by Eddy so maybe that's an important note, although I'm not really sure whether this email is still alive
) | ||
# Configure other parameters as needed. | ||
|
||
file_access_source = RandomAccessSource(file_path=file_path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to do like this:
with RandomAccessSource(file_path=file_path) as file_access_source: ...
The file will in any case be automatically closed when the variable goes out of scope (as we override __del__
for the class but standard practise in python when dealing with files to use context managers and for this we also implement context manager functions for the class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replaced with suggested
printf("or\n"); | ||
printf(" %s analyze <command> --file <path/to/file.jpg> --save <path/to/save.jpg> [--license <KEY>]\n", prog); | ||
printf("or\n"); | ||
printf(" %s parse <command> --text \"<input>\" [--license <KEY>]\n\n", prog); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Live should be added here, shouldn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added inside of main/utils/readme live command usage
…nside of analyze_multi_page python
No description provided.