Skip to content

Conversation

yurii-scanbot
Copy link
Collaborator

No description provided.

@yurii-scanbot yurii-scanbot changed the title Prepare for stable RC Prepare/restructure for stable RC Aug 18, 2025
@yurii-scanbot yurii-scanbot marked this pull request as ready for review September 3, 2025 11:15
}

// TODO Add your SCANBOTSDK_API_TOKEN and SCANBOTSDK_VERSION here.
// They are available on request via [email protected]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are available on request via [email protected]

Probably no need to remove this line

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed [email protected] in all places

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should keep them in all the places? It was added initially by Eddy so maybe that's an important note, although I'm not really sure whether this email is still alive

)
# Configure other parameters as needed.

file_access_source = RandomAccessSource(file_path=file_path)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to do like this:
with RandomAccessSource(file_path=file_path) as file_access_source: ...
The file will in any case be automatically closed when the variable goes out of scope (as we override __del__ for the class but standard practise in python when dealing with files to use context managers and for this we also implement context manager functions for the class

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replaced with suggested

printf("or\n");
printf(" %s analyze <command> --file <path/to/file.jpg> --save <path/to/save.jpg> [--license <KEY>]\n", prog);
printf("or\n");
printf(" %s parse <command> --text \"<input>\" [--license <KEY>]\n\n", prog);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Live should be added here, shouldn't it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added inside of main/utils/readme live command usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants