Skip to content

Emit deadlock under heavy load from asp.net due to missing synch. con… #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Emit deadlock under heavy load from asp.net due to missing synch. con… #401

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/SocketIOClient/Transport/WebSockets/WebSocketTransport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,13 @@ public override async Task SendAsync(IList<SerializedItem> items, CancellationTo
if (items[0].Type == SerializedMessageType.Text)
{
var bytes = Encoding.UTF8.GetBytes(items[0].Text);
await SendAsync(TransportMessageType.Text, bytes, cancellationToken);

///// This causes deadlock on _sendLock.WaitAsync above
//await SendAsync(TransportMessageType.Text, bytes, cancellationToken);
/////// Should be
await SendAsync(TransportMessageType.Text, bytes, cancellationToken).ConfigureAwait(false);
///////

Debug.WriteLine($"[WebSocket⬆] {items[0].Text}");
}

Expand Down
Loading