Always ignore missing generic type for ClassMetadata and DocumentPersister
#2839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
GromNaN
force-pushed
the
phpstan-cleanup
branch
from
7d843aa to
e7383a5
Compare
GromNaN
changed the title
ClassMetadataClassMetadata<object>
GromNaN
changed the title
ClassMetadata<object>ClassMetadata<object> and DocumentPersister<object>
…ecify the expected type
GromNaN
force-pushed
the
phpstan-cleanup
branch
from
c0cd5fb to
24003bc
Compare
GromNaN
changed the title
ClassMetadata<object> and DocumentPersister<object>ClassMetadata and DocumentPersister
GromNaN
commented
Sep 30, 2025
| path: tests/Doctrine/ | ||
|
|
||
| - message: '#with generic class Doctrine\\ODM\\MongoDB\\Mapping\\ClassMetadata does not specify its types: T$#' | ||
| - message: '#generic class Doctrine\\ODM\\MongoDB\\(Mapping\\ClassMetadata|Persisters\\DocumentPersister) (but )?does not specify its types\: T$#' |
There was a problem hiding this comment.
Discussed with @alcaeus, we could probably remove this once every class is property typed with generic subtype.
alcaeus
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In many places, the code deals with a generic
ClassMetadatainstances, having to specify theClassMetadata<object>everywhere is pointless.