Upstream GDC patch to mangle va_list as a pointer. #7563
Merged
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default behaviour is to raise an internal compiler error and exit if cppmangle encounters a static array parameter. This is not compatible with how GDC represents va_lists internally. In the codegen pass, GDC will saturate a va_list to a pointer if its underlying type is a static array.
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
|
Are arbitrary GDC/LDC-only patches accepted now? We have a few of these too… |
|
@klickverbot Obviously we should all aim at reducing the need for |
|
This wouldn't be so arbitrary if it was a condition-less runtime call. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behaviour is to raise an internal compiler error and exit if cppmangle encounters a static array parameter. This is not compatible with how GDC represents va_lists internally.
In the codegen pass, GDC will saturate a va_list to a pointer if its underlying type is a static array.
Patch taken from #2194
However... I think that a better way to do this would be to move it to a backend hook, such as
Target.cppTypePassedAs(Type t).