Skip to content

Fix #21280 - Add __NR_getrandom aka SYS_getrandom #21300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2025
Merged

Fix #21280 - Add __NR_getrandom aka SYS_getrandom #21300

merged 1 commit into from
May 1, 2025

Conversation

0xEAB
Copy link
Member

@0xEAB 0xEAB commented Apr 25, 2025

No description provided.

@0xEAB 0xEAB requested a review from ibuclaw April 25, 2025 00:28
@0xEAB 0xEAB linked an issue Apr 25, 2025 that may be closed by this pull request
Add __NR_getrandom #21280
Closed
@0xEAB
Copy link
Member Author

0xEAB commented Apr 25, 2025 •
edited
Loading

Buildkite failure looks unrelated: gecko0307/dagon#106

@0xEAB 0xEAB added the Review:Blocking Other Work review and pulling should be a priority label Apr 27, 2025
@0xEAB
Copy link
Member Author

0xEAB commented Apr 27, 2025

dlang/phobos#10748 depends on this addition to D runtime.

thewilsonator
thewilsonator approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good

ibuclaw
ibuclaw reviewed Apr 28, 2025
View reviewed changes
druntime/src/core/sys/linux/sys/syscall.d Outdated
// <asm/unistd.h>
// List the numbers of the system calls the system knows.
version (X86_64)
{
version (D_X32)
enum __NR_perf_event_open = 0x40000000 + 298;
{
enum __X32_SYSCALL_BIT = 0x40000000;
Copy link
Member

@ibuclaw ibuclaw Apr 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this symbol is better private, it's not useful outside this module.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright :)

@0xEAB 0xEAB force-pushed the SYS_getrandom branch from 022026a to bd1e012 Compare May 1, 2025 00:35
@0xEAB
Copy link
Member Author

0xEAB commented May 1, 2025

FreeBSD failure looks unrelated:

Tearing down VM
  Terminating VM
  /usr/bin/sudo kill -s TERM 1904
  kill: (1904): No such process
Error: The process '/usr/bin/ssh' failed with exit code 2

@ibuclaw
Copy link
Member

ibuclaw commented May 1, 2025

Yeah, let's do this.

@ibuclaw ibuclaw merged commit d8ea169 into dlang:master May 1, 2025
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibuclaw ibuclaw ibuclaw left review comments

@thewilsonator thewilsonator thewilsonator approved these changes

Assignees
No one assigned
Labels
Druntime Specific to druntime OS:Linux Review:Blocking Other Work review and pulling should be a priority Severity:Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add __NR_getrandom
3 participants
@0xEAB @ibuclaw @thewilsonator