fix(parser): attributes are not always propagated/populated #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Eyal Lotem <[email protected]> Signed-off-by: Luís Ferreira <[email protected]>
|
Still requires testing. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #466 +/- ##
==========================================
+ Coverage 83.17% 83.20% +0.03%
==========================================
Files 11 11
Lines 8338 8338
==========================================
+ Hits 6935 6938 +3
+ Misses 1403 1400 -3
Continue to review full report at Codecov.
|
|
we have the XPath based testing framework setup for this, I think that's the easiest way to test for an AST modification like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Eyal Lotem [email protected]
Signed-off-by: Luís Ferreira [email protected]
Adapted from weka@caac5e4 to upstream. CC @EyalIO .
Fixes #370 and somewhat related to #73.