Allows saving a file after introducing read-only mode #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I happened to have introduced a bug with pr #11 🙁
SOPS was no longer able to save the file as the buffer was read-only.
Invoking
sops-save-file
returned*Messages*
buffer:funcall-interactively: Buffer is read-only: #<buffer foo.yaml>
.Manually disabling read-only-mode before invoking
sops-edit-file
made it possible to encrypt the file withsops-save-file
.I've fixed this by disabling
read-only-mode
before the buffer is erased and re-enablingread-only-mode
when the buffer is saved. This allows for editing and saving a sops encrypted file, while still preventing the user from accidentally editing an encrypted file (hence the need to enable read-only-mode again).Sorry for the inconvenience.