Skip to content

Conversation

@smithdc1
Copy link
Member

Need to look at the new aria-describedby references in more detail. I think we likely need to update the id created by this template pack for both help_text and errors.

@smithdc1 smithdc1 force-pushed the django52 branch 4 times, most recently from 134a80b to fabcd37 Compare May 12, 2025 18:23
@smithdc1 smithdc1 force-pushed the django52 branch 4 times, most recently from 27944c2 to 8757039 Compare May 21, 2025 09:40
@scpaes
Copy link

scpaes commented May 21, 2025

I’d like to contribute by confirming Django 5.2 support, and I noticed there’s already an open pull request for that. Let me know if I can do anything to help.

@smithdc1
Copy link
Member Author

smithdc1 commented May 22, 2025

@scpaes if you could check that these changes don't break anything in your projects that would be super helpful.

I think this is close now, I just need to fix the remaining test failures.

@scpaes
Copy link

scpaes commented May 23, 2025

@scpaes if you could check that these changes don't break anything in your projects that would be super helpful.

I think this is close now, I just need to fix the remaining test failures.

I've just tested it in my main project, but due to some dependency conflicts, I wasn't able to properly verify the changes. So, I created a new Django project using version 5.2, and everything seems to be working fine.

Screencast.From.2025-05-23.08-54-39.mp4

@smithdc1 smithdc1 marked this pull request as ready for review June 8, 2025 07:48
@smithdc1
Copy link
Member Author

smithdc1 commented Jun 8, 2025

@scpaes -- thanks for checking.

@smithdc1 smithdc1 merged commit 5831872 into main Jun 8, 2025
6 checks passed
@smithdc1 smithdc1 deleted the django52 branch June 8, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants