Skip to content

fix: Ensured transactional safety when writing to redis #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: Ensured transactional safety when writing to redis #296

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2db33e8
fix: Ensured transactional safety when writing to redis
sliverc Sep 9, 2025
060a96b
Merge branch 'master' into save_safety
cunla Sep 15, 2025
ee0486b
restore _dirty_fields
cunla Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions scheduler/redis_models/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,10 @@ def exists(cls, name: str, connection: ConnectionType) -> bool:

@classmethod
def delete_many(cls, names: List[str], connection: ConnectionType) -> None:
for name in names:
connection.delete(cls._element_key_template.format(name))
with connection.pipeline() as pipeline:
for name in names:
pipeline.delete(cls._element_key_template.format(name))
pipeline.execute()

@classmethod
def get(cls, name: str, connection: ConnectionType) -> Optional[Self]:
Expand All @@ -183,7 +185,7 @@ def get_many(cls, names: Sequence[str], connection: ConnectionType) -> List[Opti
for name in names:
pipeline.hgetall(cls._element_key_template.format(name))
values = pipeline.execute()
return [(cls.deserialize(decode_dict(v, set())) if v else None) for v in values]
return [(cls.deserialize(decode_dict(v, set())) if v else None) for v in values]

def save(self, connection: ConnectionType, save_all: bool = False) -> None:
save_all = save_all or self._save_all
Expand Down
Loading