🧑💻 Replace black/isort with ruff #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
sergei-maertens
force-pushed
the
chore/switch-to-ruff
branch
from
86415e1 to
e8dd90c
Compare
The invalid cases were not properly being used, reported by ruff. The tests have been updated to pytest-style so we can parametrize the inputs more easily.
Property based testing is better at finding bad examples than manual, accidental inputs.
Suppressed one warning where the perf approach hurts readability too much.
Automatic upgrade for the modern type annotations. Some manual fixes were required for the string interpolation. Along the way, the varname for an individual cookie is deprecated. A code search in Github revealed that the accepted_cookies template tag does not appear to be used in any public projects. Deprecating it should be safe - I also can't really imagine how/why you'd use this tag as it's documented and more common to check whether an entire cookie group is accepted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.