components v2 #426
Merged
components v2 #426
+1,332
−436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topi314
force-pushed
the
feature/components-v2
branch
from
6f3877c to
b9dc7f3
Compare
|
TODO:
|
topi314
force-pushed
the
feature/components-v2
branch
from
b9dc7f3 to
a4c16e4
Compare
topi314
force-pushed
the
feature/components-v2
branch
from
90a29dd to
bac9837
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the component system to version 2 by replacing the old ContainerComponent types with LayoutComponent types throughout the codebase. Key changes include renaming and updating methods and builders (e.g., SetComponents, AddComponents, etc.), updating JSON unmarshaling for modal interactions, and adjusting tests and examples to align with the new design.
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| _examples/componentsv2/example.go | New example demonstrating usage of the v2 component structure |
| discord/component_iter.go and _test.go | New iterator implementation and test for iterating over LayoutComponents |
| discord/select_menu.go | Updated select menu components to use LayoutComponent and new method names |
| discord/interaction_modal_submit.go | Modified JSON unmarshaling for modal submit interactions to use a slice of LayoutComponent |
| discord/_builder.go / message.go | Refactored builder methods and message structures to replace ContainerComponent with LayoutComponent |
| discord/interaction_component.go | Refactored variable declarations for consistency |
| _examples/test/examplebot.go | Updated import order to support component v2 changes |
Comments suppressed due to low confidence (1)
discord/interaction_modal_submit.go:101
- The updated unmarshaling logic now directly appends container components without iterating over subcomponents as before. Please verify that flattening nested components is no longer required for ModalSubmitInteractionData.
components = append(components, containerComponent.Component.(LayoutComponent))
apricotbucket28
pushed a commit
to apricotbucket28/disgo
that referenced
this pull request
Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.