A bunch of random improvements #58
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -115,12 +117,13 @@ await GetPackageDependencies( | |||
|
|
|||
| foreach (var path in libraries) | |||
| { | |||
| var assembly = Assembly.LoadFrom(path); | |||
| if (context.TryAddReferenceAssembly(assembly)) | |||
| var asm = Assembly.LoadFile(path); | |||
There was a problem hiding this comment.
Suggested change
| var asm = Assembly.LoadFile(path); | |
| var assembly = Assembly.LoadFile(path); |
There was a problem hiding this comment.
I think these should be split into separate files at this point.
There was a problem hiding this comment.
I can do that, was just leaving it as I found it originally
There was a problem hiding this comment.
Yes, I think we should for the sake of maintainability for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.