Temporary image path fix for HTTPS. #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for making this available. I agree about not merging this in favour a more permanent solution. Regarding self-hosting could we not get it from here https://github.com/developmentseed/openlayers_themes/tree/master/dark? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you want to use maps over HTTPS, you will also need a HTTPS URL for the theme images. I'm not sure this is a good idea long term, since the cloudfront URL might change, but I haven't been able to find a place where we can download the theme so the libraries can self-host. And the default theme is terrible.
So, consider this a temporary workaround. We might consider not merging it.