WIP: Convex hull invalid topology #353
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test incorrectly passing, this also explores adding rerun for algorithm visualization.
The main cause of the issue is not found, but hopefully a smaller subset of points will lead to easier debugging.
increasing the epsilon (
* 10
=0.0034526698
) from https://github.com/Vrixyz/parry/blob/d5dc99b4760270c5d82d78098b4124b01529b149/src/shape/convex_polyhedron.rs#L234 fixes the test. I'd like to know why exactly though, Ideally we'd have some insurance that previously generated mesh can't trigger this incorrect behaviour.investigation of epsilon fix
On failing test, The dot product of triangles from offending edges are:
> 1.0 - 0.0034526698
is false)So this raises the question that increasing the epsilon is probably not enough, as such case could happen again.
Our test case looks like (red edges are removes, so last edge is ambiguous to create a triangle from (results in 2 triangles up and leads to a bigger triangle):
2 options: