DB Query Engine #2265
Open
DB Query Engine #2265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discovered a flaw in sqlstore's handling of wildcard perms during testing, adjusted Adjustd the s3 store to enable testing with this definition instead of separate mock Added tests for different aspects of the query engine, especially rbac and unit management.
motatoes
reviewed
Oct 10, 2025
| // Initialize analytics with system ID management (always create system ID) | ||
| analytics.InitGlobalWithSystemID("production", store) | ||
|
|
||
| // 3. Create the base OrchestratingStore |
There was a problem hiding this comment.
- is redundant in comment, where is 1 and 2?
| analytics.InitGlobalWithSystemID("production", store) | ||
|
|
||
| // 3. Create the base OrchestratingStore | ||
| orchestratingStore := storage.NewOrchestratingStore(blobStore, queryStore) |
There was a problem hiding this comment.
this orchestrating store is grouping blobStore and queryStore which are both unrelated it seems, just use UnitStore and QueryStore independently ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds modular DB backing, allow bucketstore abstraction.
Note: a large amount of the LOC change is the test suite and data.