Change the behaviour of Repetition and Integer max constructor arguments #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re: #394. The *max* constructor arguments of the Repetition and Integer class- es are now treated as inclusive, rather than exclusive. This seems more sensible and matches the treatment of the *min* argument. For the Integer class, I have elected not to change the complex int- ernal classes that do the most of the work. They receive the value *max + 1*. This shouldn't matter, but I'm noting it here. The Digits element class is affected by this change, as it is a sub- class of Repetition.
Re changes to Repetition and Integer *max* constructor arguments.
drmfinlay
force-pushed
the
feat/max-element-changes
branch
from
8183ef6 to
386f9be
Compare
Re: #394. The OneOrMore element class is a sub-class of Repetition which matc- hes a child element one or more times -- i.e. Kleene plus behaviour. The default maximum number of repetitions is sixteen and can be adj- usted via the class member *default_max*. OneOrMore is a simpler way of using Dragonfly's Repetition element for what is commonly called Continuous Command Recognition (CCR).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #394.
The max constructor arguments of the Repetition and Integer classes are now treated as inclusive, rather than exclusive. This seems more sensible and matches the treatment of the min argument.
For the Integer class, I have elected not to change the complex internal classes that do the most of the work. They receive the value max + 1. This shouldn't matter, but I'm noting it here.
The Digits element class is affected by this change, as it is a subclass of Repetition.
Repetition and number element test cases have been updated appropriately.