-
Notifications
You must be signed in to change notification settings - Fork 0
Cleanup #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
liss-h
wants to merge
41
commits into
develop
Choose a base branch
from
fix/cleanup
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Cleanup #13
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
35f444e
formatting
Clueliss 5b3890f
update to c++20
Clueliss 2e66267
proper iterator deref types
Clueliss bab0712
eliminate some const casts
Clueliss 47cc81f
cleanup sparse array
Clueliss 703d4a5
seperate sparse hash file
Clueliss ba927dd
cleanup policies
Clueliss 2cdf1a5
revert some things in sparse array
Clueliss 1729915
remove last field from array and remove scoped alloc awareness from a…
Clueliss fa4efa2
utilize memmove
Clueliss bdb2ac9
more memmove
Clueliss 43c26e4
attempt to optimize offset_to_index
Clueliss f4ec70b
port to doctest
Clueliss 0c79106
sparse buckets array v1
Clueliss 16273b8
sparse buckets array cleanup
Clueliss a9d8263
getting rid of more members
Clueliss 64fa09a
throw out boost and update readme and stuff
Clueliss 96802e8
optimize bucket array
Clueliss f082ce5
exclude .idea folder
Clueliss 3f30390
rework folder structure
Clueliss 0d3cab7
fix bugs
Clueliss 6eeb9d2
prettify
Clueliss e6c42ad
Avoid iterator invalidation without effective insert
Clueliss db1246b
if constexpr
Clueliss 8e48c62
try fix ci
Clueliss 24ad3b0
try fix ci
Clueliss 36be0fc
try fix ci
Clueliss 47336df
try fix ci
Clueliss 77aae68
try fix ci
Clueliss 40d1524
try fix ci
Clueliss 03844a4
try fix ci
Clueliss 7e65d7f
try fix ci
Clueliss 502eff3
try fix ci
Clueliss aa995f9
missing typename
Clueliss a43a320
missing include
Clueliss 7bbc7cd
fix test package
Clueliss 5add00e
comment out macos runners and only run on pr
Clueliss 49941e0
no tsl debug
Clueliss fb4447a
address review 1
Clueliss d20ef3a
deprecate range erase
Clueliss 73eafa4
small optim
Clueliss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,104 +1,108 @@ | ||
| name: CI | ||
|
|
||
| on: [push, pull_request, release] | ||
| on: [ pull_request ] | ||
|
|
||
| jobs: | ||
| build: | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| config: | ||
| - { | ||
| name: linux-x64-clang-9, | ||
| os: ubuntu-18.04, | ||
| cxx: clang++-9, | ||
| cmake-build-type: Release | ||
| } | ||
| - { | ||
| name: macos-x64-gcc, | ||
| os: macos-10.15, | ||
| cxx: g++, | ||
| cmake-build-type: Release | ||
| } | ||
| - { | ||
| name: macos-x64-clang, | ||
| os: macos-10.15, | ||
| cxx: clang++, | ||
| cmake-build-type: Release | ||
| } | ||
| - { | ||
| name: linux-x64-clang-12-sanitize, | ||
| os: ubuntu-20.04, | ||
| cxx: clang++-12, | ||
| cxx-flags: "-fsanitize=address,undefined", | ||
| cmake-build-type: Release | ||
| } | ||
| - { | ||
| name: linux-x64-gcc-10-coverage, | ||
| os: ubuntu-20.04, | ||
| cxx: g++-10, | ||
| cxx-flags: --coverage, | ||
| gcov-tool: gcov-10, | ||
| cmake-build-type: Debug | ||
| } | ||
| - { | ||
| name: linux-x64-clang-11, | ||
| os: ubuntu-20.04, | ||
| cxx: clang++-11, | ||
| cmake-build-type: Release | ||
| } | ||
| - { | ||
| name: linux-x64-clang-12, | ||
| os: ubuntu-22.04, | ||
| cxx: clang++-12, | ||
| cmake-build-type: Release | ||
| } | ||
| - { | ||
| name: linux-x64-clang-13, | ||
| os: ubuntu-22.04, | ||
| cxx: clang++-13, | ||
| cmake-build-type: Release | ||
| } | ||
| - { | ||
| name: linux-x64-clang-14, | ||
| os: ubuntu-22.04, | ||
| cxx: clang++-14, | ||
| cmake-build-type: Release | ||
| } | ||
| - { | ||
| name: linux-x64-gcc-11, | ||
| os: ubuntu-22.04, | ||
| cxx: g++-11, | ||
| cmake-build-type: Release | ||
| } | ||
| name: ${{matrix.config.name}} | ||
| # These get queued but never actually run | ||
| #- name: macos-x64-gcc, | ||
| # os: macos-13.5, | ||
| # cxx: g++, | ||
| #- name: macos-x64-clang, | ||
| # os: macos-13.5, | ||
| # cxx: clang++, | ||
|
|
||
| - name: linux-x64-clang-14 | ||
| os: ubuntu-22.04 | ||
| cxx: clang++-14 | ||
|
|
||
| - name: linux-x64-clang-15 | ||
| os: ubuntu-22.04 | ||
| cxx: clang++-15 | ||
|
|
||
| - name: linux-x64-clang-16-sanitize | ||
| os: ubuntu-22.04 | ||
| cxx: clang++-16 | ||
| cxx-flags: -fsanitize=undefined -fsanitize=address -fno-omit-frame-pointer -fno-optimize-sibling-calls | ||
|
|
||
| - name: linux-x64-gcc-11-coverage | ||
| os: ubuntu-22.04 | ||
| cxx: g++-11 | ||
| cxx-flags: --coverage | ||
| gcov-tool: gcov-11 | ||
|
|
||
| - name: linux-x64-gcc-12 | ||
| os: ubuntu-22.04 | ||
| cxx: g++-12 | ||
|
|
||
| - name: linux-x64-gcc-13 | ||
| os: ubuntu-22.04 | ||
| cxx: g++-13 | ||
|
|
||
| runs-on: ${{matrix.config.os}} | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
|
|
||
| # Linux or macOS | ||
| - name: Install boost (Linux or macOS) | ||
| run: vcpkg install boost-test boost-container boost-interprocess | ||
| if: runner.os == 'Linux' || runner.os == 'macOS' | ||
|
|
||
| - name: Configure CMake (Linux or macOS) | ||
| run: cmake -DCMAKE_BUILD_TYPE=${{matrix.config.cmake-build-type}} -DCMAKE_TOOLCHAIN_FILE="$VCPKG_INSTALLATION_ROOT/scripts/buildsystems/vcpkg.cmake" -S ${{github.workspace}}/tests -B ${{github.workspace}}/build | ||
| env: | ||
| CXX: ${{matrix.config.cxx}} | ||
| CXXFLAGS: ${{matrix.config.cxx-flags}} | ||
| if: runner.os == 'Linux' || runner.os == 'macOS' | ||
|
|
||
| - name: Build (Linux or macOS) | ||
| run: cmake --build ${{github.workspace}}/build --verbose | ||
| if: runner.os == 'Linux' || runner.os == 'macOS' | ||
|
|
||
| - name: Test (Linux or macOS) | ||
| run: ${{github.workspace}}/build/tsl_sparse_map_tests | ||
| if: runner.os == 'Linux' || runner.os == 'macOS' | ||
|
|
||
| - name: Coverage | ||
| run: | | ||
| sudo apt-get install -y lcov | ||
| lcov -c -b ${{github.workspace}}/include -d ${{github.workspace}}/build -o ${{github.workspace}}/coverage.info --no-external --gcov-tool ${{matrix.config.gcov-tool}} | ||
| bash <(curl -s https://codecov.io/bash) -f ${{github.workspace}}/coverage.info | ||
| if: ${{matrix.config.name == 'linux-x64-gcc-10-coverage'}} | ||
| - name: Add Repos for for gcc-13 and clang-16 | ||
| run: | | ||
| # gcc-13 | ||
| sudo add-apt-repository ppa:ubuntu-toolchain-r/test -y | ||
| # clang-16 | ||
| source /etc/os-release | ||
| echo "deb http://apt.llvm.org/${UBUNTU_CODENAME}/ llvm-toolchain-${UBUNTU_CODENAME}-16 main" | sudo tee /etc/apt/sources.list.d/llvm-16.list | ||
| curl https://apt.llvm.org/llvm-snapshot.gpg.key | gpg --dearmor | sudo tee /etc/apt/trusted.gpg.d/llvm-16.gpg > /dev/null | ||
| sudo apt-get update -y | ||
| if: runner.os == 'Linux' | ||
|
|
||
| - name: Install compiler | ||
| id: install_cc | ||
| uses: rlalik/[email protected] | ||
| with: | ||
| compiler: ${{ matrix.config.cxx }} | ||
| if: runner.os == 'Linux' | ||
|
|
||
| - name: Check out sources | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Install boost (Linux) | ||
| run: sudo apt-get install -y libboost-dev | ||
| if: runner.os == 'Linux' | ||
|
|
||
| - name: Install boost (macOS) | ||
| run: vcpkg install boost-interprocess | ||
| if: runner.os == 'macOS' | ||
|
|
||
| - name: Configure CMake (Linux) | ||
| run: cmake -DBUILD_TESTING=ON -DCMAKE_BUILD_TYPE=Debug -B build | ||
| env: | ||
| CXX: ${{matrix.config.cxx}} | ||
| CXXFLAGS: ${{matrix.config.cxx-flags}} | ||
| if: runner.os == 'Linux' | ||
|
|
||
| - name: Configure CMake (macOS) | ||
| run: cmake -DBUILD_TESTING=ON -DCMAKE_BUILD_TYPE=Debug -DCMAKE_TOOLCHAIN_FILE="$VCPKG_INSTALLATION_ROOT/scripts/buildsystems/vcpkg.cmake" -B build | ||
| env: | ||
| CXX: ${{matrix.config.cxx}} | ||
| CXXFLAGS: ${{matrix.config.cxx-flags}} | ||
| if: runner.os == 'macOS' | ||
|
|
||
| - name: Build | ||
| working-directory: build | ||
| run: cmake --build . --verbose --parallel 2 | ||
| if: runner.os == 'Linux' || runner.os == 'macOS' | ||
|
|
||
| - name: Test | ||
| working-directory: build | ||
| run: ctest --parallel 2 --verbose | ||
| if: runner.os == 'Linux' || runner.os == 'macOS' | ||
|
|
||
| - name: Coverage | ||
| run: | | ||
| sudo apt-get install -y lcov | ||
| lcov -c -b ${{github.workspace}}/include -d ${{github.workspace}}/build -o ${{github.workspace}}/coverage.info --no-external --gcov-tool ${{matrix.config.gcov-tool}} | ||
| bash <(curl -s https://codecov.io/bash) -f ${{github.workspace}}/coverage.info | ||
| if: ${{matrix.config.name == 'linux-x64-gcc-11-coverage'}} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When merged, we should add issues with tag help-wanted to add windows and macos support to the CI.