fix: deps deploy works with Canister ID out of the ranges of the pocket-ic subnets #4276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
dfx deps deploy
command didn't work when the pulled dependency's Canister ID is out of the ranges of thepocket-ic
subnets.The removed
replica
had one subnet to cover all subnets. While thepocket-ic
can dynamically create new subnet when trying to create a canister with specified ID.There was a step to read controllers of the specified ID. Such check used to always succeed when running on a local
replica
. But it may fail withpocket-ic
because the subnets doesn't cover the Canister ID. The read controllers step is adjusted to reflect thepocket-ic
bahavior.How Has This Been Tested?
Replaced a Canister ID being used in the
deps.bash
e2e tests.The new ID is out of the ranges of the pockt-ic subnets.
Checklist: