Skip to content

fix: deps deploy works with Canister ID out of the ranges of the pocket-ic subnets #4276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lwshang
Copy link
Contributor

@lwshang lwshang commented Jun 13, 2025

Description

The dfx deps deploy command didn't work when the pulled dependency's Canister ID is out of the ranges of the pocket-ic subnets.

The removed replica had one subnet to cover all subnets. While the pocket-ic can dynamically create new subnet when trying to create a canister with specified ID.

There was a step to read controllers of the specified ID. Such check used to always succeed when running on a local replica. But it may fail with pocket-ic because the subnets doesn't cover the Canister ID. The read controllers step is adjusted to reflect the pocket-ic bahavior.

How Has This Been Tested?

Replaced a Canister ID being used in the deps.bash e2e tests.
The new ID is out of the ranges of the pockt-ic subnets.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@lwshang lwshang marked this pull request as ready for review June 13, 2025 16:53
@lwshang lwshang requested a review from a team as a code owner June 13, 2025 16:53
@lwshang lwshang enabled auto-merge (squash) June 13, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant