refactor(governance): Source definitions of Subnet Rental canister request and response types from authoritative source. #6722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-wong-dfinity-org
force-pushed
the
source-subnet-rental-canister-request-and-response-types-daniel-wong
branch
3 times, most recently
from
85d4a34 to
59326f6
Compare
…es from the authoritative source, the dfinity/subnet-rental-canister GitHub repository.
daniel-wong-dfinity-org
force-pushed
the
source-subnet-rental-canister-request-and-response-types-daniel-wong
branch
from
59326f6 to
7c433de
Compare
…esponse types from older code in governance and ic-admin.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 17, 2025
…t Rental canister API types. (#6778) # Related Work In [PR 6722], I tried sourcing the definition of these types from the the true authoritative source, the [subnet-rental-canister repo][src]. Unfortunately, that created various headaches. The headache that convinced me to abandon the aforementioned PR was how it increased the size of the NNS Governance WASM. The increase was not super big, but since WASM size is a more or less scarce resource, I didn't want to eat into our remaining headroom. Therefore, I went for this less ambitious PR instead. [PR 6722]: #6722 [src]: https://github.com/dfinity/subnet-rental-canister # References Closes [NNS1-3965]. [NNS1-3965]: https://dfinity.atlassian.net/browse/NNS1-3965
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To wit, https://github.com/dfinity/subnet-rental-canister .
This requires un-merged changes in the subnet-rental-canister repo.
This is being abandoned in favor of PR 6778, because this creates a bunch of headaches. With a bit of massaging, we can probably get past those with a bit more effort. However, there's one headache that has convinced me to abandon this PR: this increases the size of the NNS Governance WASM. The increase isn't huge, but since we have limited headroom, I think we need to conserve what we have left, and not just let it grow when there is not a "big" benefit from the change. The benefit here seems "not big enough" on the basis that this doesn't add any new features, nor fix any incorrect behaviors, nor increase performance, etc.