feat: flux cd deployment #6660
feat: flux cd deployment #6660
Conversation
kartik-579
requested review from
prakarsh-dt,
pawan-mehta-dt,
nishant-d,
vikramdevtron and
vivek-devtron
as code owners
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9257608 | Triggered | Base64 AWS keys | 6fcdfe3 | scripts/devtron-reference-helm-charts/deployment-chart_4-22-0/test-values.json | View secret |
| 2763127 | Triggered | Generic High Entropy Secret | 6fcdfe3 | scripts/devtron-reference-helm-charts/deployment-chart_4-22-0/secrets-test-values.yaml | View secret |
| 141558 | Triggered | Generic High Entropy Secret | d5e2b08 | scripts/devtron-reference-helm-charts/reference-chart_5-2-0/env-values.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| {{- if $.Values.topologySpreadConstraint }} | ||
| topologySpreadConstraints: | ||
| {{ toYaml .Values.topologySpreadConstraint }} | ||
| {{- end }} |
Check warning
Code scanning / SonarCloud
Service account permissions should be restricted Medium
| {{- end}} | ||
| {{- end}} | ||
| containers: | ||
| - name: {{ $.Chart.Name }} |
Check warning
Code scanning / SonarCloud
Memory limits should be enforced Medium
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
* cd pipeline crud * cd pipeline cryd * async flow handling * dep fix * fix condition
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
* wip * deployment status flow for flux cd app * resource tree change * wip: deployment status changes
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
github-actions
bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
|
Description
Fixes https://github.com/devtron-labs/sprint-tasks/issues/2377
Checklist:
Does this PR introduce a user-facing change?