-
Notifications
You must be signed in to change notification settings - Fork 3
docs: OCI Pull/Push Doc Revision #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR revises the OCI Pull/Push documentation by removing the outdated OCI pull documentation and replacing it with new comprehensive documentation for deploying software to air-gapped environments. The revision improves clarity and provides updated guidance for using Devtron's OCI features in various scenarios.
Key changes:
- Removed the existing OCI pull documentation
- Added new air-gapped deployment use case documentation
- Updated references and links throughout the documentation
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
docs/user-guide/use-cases/oci-pull.md |
Completely removed existing OCI pull documentation |
docs/user-guide/use-cases/airgapped-app-deployment.md |
Added comprehensive documentation for air-gapped environment deployments |
docs/user-guide/use-cases/README.md |
Added reference to new air-gapped deployment documentation |
docs/user-guide/plugins/copy-container-image.md |
Updated reference link for container registry configuration |
docs/user-guide/global-configurations/container-registries.md |
Extensively revised and restructured container registry documentation |
docs/user-guide/global-configurations/cluster-and-environments.md |
Added informational note about cluster credentials |
docs/user-guide/creating-application/workflow/cd-pipeline.md |
Minor text improvements and duplicate content fix |
docs/SUMMARY.md |
Updated navigation to reference new air-gapped deployment documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
In fully air-gapped environments with no Internet access, the vendor and client may rely on physical transfer of Helm packages. Devtron facilitates this as follows: | ||
|
||
1. **Vendor Action:** | ||
- Similar to [Scanario 1](#scenario-1-air-gapped-cluster-has-access-to-oci-registry), the vendor generates a helm package by deploying the application to an [isolated cluster](../global-configurations/cluster-and-environments.md#add-isolated-cluster). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo in the reference link text. 'Scanario' should be 'Scenario'.
- Similar to [Scanario 1](#scenario-1-air-gapped-cluster-has-access-to-oci-registry), the vendor generates a helm package by deploying the application to an [isolated cluster](../global-configurations/cluster-and-environments.md#add-isolated-cluster). | |
- Similar to [Scenario 1](#scenario-1-air-gapped-cluster-has-access-to-oci-registry), the vendor generates a helm package by deploying the application to an [isolated cluster](../global-configurations/cluster-and-environments.md#add-isolated-cluster). |
Copilot uses AI. Check for mistakes.
@@ -44,7 +44,7 @@ This section expects four inputs from you: | |||
In case you are choosing an [isolated environment](../../global-configurations/cluster-and-environments.md#add-isolated-cluster) for deployment, you will get two additional options to choose from in the 'Deploy to Environment' window ([check snapshot](https://devtron-public-asset.s3.us-east-2.amazonaws.com/images/use-cases/oci-push/create-cd2.jpg)): | |||
* **Do not push** - A link to download the helm package will be available after the deployment. However, it will not push the helm package to the OCI registry. | |||
* **Push to registry** - This will generate and [push the helm package to the OCI registry](../../global-configurations/container-registries.md#push-helm-packages). Upon selecting this option, you will get two more fields: | |||
* **Registry** - Choose the OCI registry to which the helm chart package must be pushed. Only those registries that have `Push helm packages` enabled will be shown in the dropdown. | |||
* **Registry** - Choose the OCI registry to which the helm chart package must be pushed. Only those registries that have [Push helm packages](../../global-configurations/container-registries.md#push-helm-packages) enabled will be shown in the dropdownChoose the OCI registry to which the helm chart package must be pushed. Only those registries that have [Push helm packages](../../global-configurations/container-registries.md#push-helm-packages) enabled will be shown in the dropdown. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's duplicate content in this line. The text 'Choose the OCI registry to which the helm chart package must be pushed. Only those registries that have Push helm packages enabled will be shown in the dropdown' appears twice, and there's a missing period after 'dropdown' in the first occurrence.
* **Registry** - Choose the OCI registry to which the helm chart package must be pushed. Only those registries that have [Push helm packages](../../global-configurations/container-registries.md#push-helm-packages) enabled will be shown in the dropdownChoose the OCI registry to which the helm chart package must be pushed. Only those registries that have [Push helm packages](../../global-configurations/container-registries.md#push-helm-packages) enabled will be shown in the dropdown. | |
* **Registry** - Choose the OCI registry to which the helm chart package must be pushed. Only those registries that have [Push helm packages](../../global-configurations/container-registries.md#push-helm-packages) enabled will be shown in the dropdown. |
Copilot uses AI. Check for mistakes.
@@ -185,7 +185,7 @@ | |||
* [Connect SpringBoot with Mysql Database](user-guide/use-cases/connect-springboot-with-mysql-database.md) | |||
* [Connect Expressjs With Mongodb Database](user-guide/use-cases/connect-expressjs-with-mongodb-database.md) | |||
* [Connect Django With Mysql Database](user-guide/use-cases/connect-django-with-mysql-database.md) | |||
* [Pull Helm Charts from OCI Registry](user-guide/use-cases/oci-pull.md) | |||
* [Deploying Software on Air-gapped Environment](../docs/user-guide/use-cases/airgapped-app-deployment.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The relative path contains an incorrect '../docs/' prefix. Since the SUMMARY.md file is already in the docs directory, the path should be 'user-guide/use-cases/airgapped-app-deployment.md' to match the pattern of other entries in the same list.
* [Deploying Software on Air-gapped Environment](../docs/user-guide/use-cases/airgapped-app-deployment.md) | |
* [Deploying Software on Air-gapped Environment](user-guide/use-cases/airgapped-app-deployment.md) |
Copilot uses AI. Check for mistakes.
Sample Preview