Skip to content

Transform array of enums in multi-options #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NoxTav
Copy link

@NoxTav NoxTav commented Apr 22, 2025

Description

Currently, when we have an array of enum, we have to fill it in JSON, but if there is an enum, we can select a possibility in an option.

There is the possibility of selecting multiple values of an enum with the multi-options.

Effects in n8n UI

Can select the values in fixed mode in the list.

Side effects

Someone wanting to have several instances of the same value would not be able to add them directly, but they can pass in expression mode and update them.

Copy link
Contributor

@devlikepro devlikepro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add one small test pls 🙏

@@ -43,6 +43,8 @@ export class N8NINodeProperties {
let type: NodePropertyTypes;
let defaultValue = this.schemaExample.extractExample(schema)

let options = undefined
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any type for options available from n8n ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the type and the test.

@NoxTav NoxTav force-pushed the transform_array_of_enums_into_multioptions branch from 16c9a30 to e72df20 Compare April 25, 2025 08:59
@NoxTav NoxTav requested a review from devlikepro April 25, 2025 09:00
@NoxTav
Copy link
Author

NoxTav commented May 14, 2025

Hi @devlikepro,
Just a friendly ping — I’ve addressed the feedback and updated the PR. When you have a moment, could you please take another look? Your review would be much appreciated. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants