Fix some TGLP values to match actual use #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checked against the system fonts. Not entirely sure what this value is meant for, then, but it caused issues for some applications when it was set improperly, and this is the closest value I could find
This causes fewer sizing problems when using a codepoint filter: if all very large glyphs were excluded, there's no point in having the cell size be that large.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not entirely certain what "default width" is supposed to be, but this is much closer to the examples that we have (i.e. all four system fonts).
Also, some fonts have highly variable glyph sizes, and filters can cause some strange issues because of that. Using only the glyphs that are included for sizing information mostly fixes that problem.