Fixes #40: Interpolated zero values are taken as false (zeros are not diplayed) #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically check that child nodes are not strictly equal to `false` so that the value zero (0) gets rendered correctly.
Also add explicit checks for `undefined` and `null` (I’ve encountered `undefined` in my testing with [Kitten](https://codeberg.org/kitten/app). Haven’t hit `null` but it would also make it panic, so better safe than sorry). We could use a lax equality comparison (`==`) here but I prefer being explicit about it (but happy either way).
aral
changed the title
odinhb
added a commit
to dodoas/stringjsx
that referenced
this pull request
Mar 8, 2024
fixes developit#40 and developit#37 inspired by developit#41 The only place we don't have parity right now is arrays (because that's how children are passed) and bigint (because I'm not gonna do dependency wrangling rn)
odinhb
added a commit
to dodoas/stringjsx
that referenced
this pull request
Mar 8, 2024
fixes developit#40 and developit#37 inspired by developit#41 The only place we don't have parity right now is arrays (because that's how children are passed) and bigint (because I'm not gonna do dependency wrangling rn)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables vhtml to render interpolated numeric zero values.
See #40