Add flag for displaying only IPs of VMs, as per the query #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devdinu
requested changes
Mar 6, 2020
|
|
||
| for _, ins := range insts { | ||
| fmt.Printf("%s\n", ins) | ||
| } |
There was a problem hiding this comment.
- we should use
bytes.Buffer - ideally would prefer having custom
type instances []instanceand defining formatted outputs from it, since that's more extensible. you could refer projects
| instanceCommand.StringVar(&instanceArgs.Regex, "regex", "", "search instances by regex") | ||
| instanceCommand.BoolVar(&instanceArgs.HostMapping, "host_mapping", false, "return the search results in `/etc/hosts` file format") | ||
| instanceCommand.BoolVar(&instanceArgs.IPOnly, "ip_only", false, "returns comma separated list of IPs for matching hosts") | ||
| instanceCommand.StringVar(&args.Login.Session, "session", "login-session", "login sesssion name") |
There was a problem hiding this comment.
we should also mentioned host_mapping takes higher priority than ip_only
| } | ||
| output = strings.TrimRight(output, ",") | ||
| fmt.Printf("%s", output) | ||
| fmt.Printf("\n") |
There was a problem hiding this comment.
we can get the ip list with our custom type Instances []Instance with IPs defined on the struct.
ips := Instances(insts).IPs()
strings.Join(ips, ",")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.