Draft: support for other Pseudopotential + downloader #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent order. I do not consider this as an error, therefore, I changed the assert comparission of maps of element-lists to maps of element-sets. Also one validation test had to be changed.
is it does not stores the element symbol.
…intuitive first block is he upper most angular momentum and after goes the s, p, d ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last year, I was playing with this package most of all for my personal needs, I decided to share my changes. They can be summarized into 3 points:
It is marked as a draft, because at some point I didn't wanted to share it so I did some ad hoc nasty changes. Then changed my mind again if you think my changes are interesting I can clean up my code.