Attach method to set color to *ModalForm #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this PR is to help to fix an issue in k9s to when spawning modal forms. An example can be found here, where the
NewModalFormfunction hardcodes the title color totcell.ColorAqua.A skin where everything is set on black, taken from here, shows that the title's color remains hardcoded, despite me setting manually in the k9s code the title color to red. This is a ss from the scale command from scale extender:
Calling
confirm.SetTitleColor(whateverColor)does not seem to work as the call does not target same destination asconfirm.frame.SetTitleColor(which is the fix).In order to not change to signature of
NewModalFormI attached the function that can help solve the issue and allow configuration of title color in k9s.