Skip to content

8 - revert when attempting to close more bonds than the position has #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

8 - revert when attempting to close more bonds than the position has #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion contracts/libraries/EverlongPortfolio.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ library EverlongPortfolioLibrary {
/// @notice Thrown on attempting to add a position to a full queue.
error QueueFull();

/// @notice Thrown when attempting to decrease a position by more than it
/// has.
error InsufficientBonds();

/// @dev The state of the portfolio which contains a double-ended queue
/// of {IEverlongStrategy.EverlongPosition} along with the portfolio's average
/// maturity, vault share price, and total bond count.
Expand Down Expand Up @@ -211,8 +215,13 @@ library EverlongPortfolioLibrary {
// Ensure there are items in the queue.
if (frontIndex == self._end) revert QueueEmpty();

// Revert if trying to decrease by an amount greater than what is
// present.
if (_amount > self._q[frontIndex].bondAmount) {
revert InsufficientBonds();
}
// Remove the position if _amount equals the position's bondAmount.
if (_amount >= self._q[frontIndex].bondAmount) {
else if (_amount == self._q[frontIndex].bondAmount) {
value = _removePosition(self);
}
// Reduce the position's bondAmount by `_amount`.
Expand Down
11 changes: 11 additions & 0 deletions test/everlong/units/Portfolio.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,4 +121,15 @@ contract TestPortfolio is EverlongTest {
"position count should be 0 after opening and closing a long for the full bond amount"
);
}

/// @dev Validates that `InsufficientBonds` error is thrown when trying
/// to decrease a position by more than its `bondAmount`.
function test_handleClosePosition_insufficient_bonds_failure() external {
// Create a position with a single bond in it.
portfolio.handleOpenPosition(1, 1);

// Attempt to close 2 bonds from the position. This should revert.
vm.expectRevert(EverlongPortfolioLibrary.InsufficientBonds.selector);
portfolio.handleClosePosition(2);
}
}
Loading