Fix incorrect HTTP referer on hard loads #397
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -376,8 +376,12 @@ function pjaxReload(container, options) { | |||
| // | |||
| // Returns nothing. | |||
| function locationReplace(url) { | |||
There was a problem hiding this comment.
In light of these changes, calling this function locationReplace doesn't make a huge amount of sense. I suggest renaming it hardLoad, which describes the functionality rather than the (old) implementation.
|
@mislav any progress on this? |
|
I will need to look into this. Thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of calling
location.replace()inlocationReplace, callhistory.back()and thenlocation.assign(). This means the new page will be loaded with the correct HTTP referer – the previous page's URL.onPjaxPopstate()shouldn't do anything when we callhistory.back(), because the popped state will be equal topjax.state.