Skip to content

Conversation

@theskcd
Copy link
Collaborator

@theskcd theskcd commented Jan 29, 2025

agent_instance: defog-ai_sql-eval_230 Tries to fix: #230

@rishsriv
Copy link
Member

/agent hmm this seems to be buggy. For example, the function run_eval_in_threadpool is not defined in most of the runners

python main.py \                  
  -db postgres \
  -q "data/instruct_basic_postgres.csv" \
  -o results/claude3_basic.csv \
  -g anthropic \
  -f prompts/prompt_anthropic.md \
  -m claude-3-5-sonnet-latest \
  -p 5
Using prompt file prompts/prompt_anthropic.md
Preparing questions...
Using all question(s) from data/instruct_basic_postgres.csv
Traceback (most recent call last):
  File "/Users/rishabh/defog/sql-eval/main.py", line 93, in <module>
    run_anthropic_eval(args)
  File "/Users/rishabh/defog/sql-eval/runners/anthropic_runner.py", line 152, in run_anthropic_eval
    output_rows, total_correct, total_tried = run_eval_in_threadpool(
                                              ^^^^^^^^^^^^^^^^^^^^^^
NameError: name 'run_eval_in_threadpool' is not defined

@theskcd
Copy link
Collaborator Author

theskcd commented Jan 29, 2025

⚠️ There was an error while processing your request:

Git error: To https://github.com/defog-ai/sql-eval.git
 ! [rejected]        defog-ai_sql-eval_230 -> defog-ai_sql-eval_230 (fetch first)
error: failed to push some refs to 'https://github.com/defog-ai/sql-eval.git'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

The error has been logged and can be investigated if needed.

@theskcd theskcd closed this Jan 29, 2025
@theskcd
Copy link
Collaborator Author

theskcd commented Jan 29, 2025

for sanity, had to create my own PR here

reason: rishsriv did a manual push to the branch and we failed to fetch it on our side, these git issues are so annoying lol, literal skill issue on our end

manual_pr after running the following:
git pull origin defog-ai_sql-eval_230 --rebase

#234

also context was running hot (180k)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor codebase so that we do not repeat code, instead of repeating similar code across multiple runners

3 participants