Skip to content

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Oct 2, 2025

per https://github.blog/changelog/2025-09-19-github-actions-macos-13-runner-image-is-closing-down/

Summary by CodeRabbit

  • Chores

    • Updated CI configuration to run the legacy Python 3.7 macOS job on the macOS-15-intel runner instead of macOS-13.
    • No changes to workflow logic, steps, or error handling.
  • Tests

    • Infrastructure-only update to test runner environment; test coverage and behavior remain unchanged.
  • Notes

    • No user-facing impact or functional changes to the product.

Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.60%. Comparing base (4389a5b) to head (a7a36b7).
⚠️ Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (4389a5b) and HEAD (a7a36b7). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (4389a5b) HEAD (a7a36b7)
15 14
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #551       +/-   ##
===========================================
- Coverage   60.40%   47.60%   -12.81%     
===========================================
  Files          39       39               
  Lines        3905     3905               
===========================================
- Hits         2359     1859      -500     
- Misses       1546     2046      +500     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

coderabbitai bot commented Oct 2, 2025

📝 Walkthrough

Walkthrough

Updated the GitHub Actions test workflow matrix to change the macOS runner for the Python 3.7 legacy job from macos-13 to macos-15-intel. No other workflow steps, logic, or control flow were modified.

Changes

Cohort / File(s) Summary of Changes
CI runner matrix update
.github/workflows/test.yml
Adjusted matrix include entry: macOS runner for Python 3.7 legacy changed from macos-13 to macos-15-intel. No other edits.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit's high-level summary is enabled.
Title Check ✅ Passed The title succinctly describes the primary change of replacing macos-13 images with macos-15-intel images in the CI workflow, matching the content of the changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4389a5b and a7a36b7.

📒 Files selected for processing (1)
  • .github/workflows/test.yml (1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.7)
.github/workflows/test.yml

31-31: label "macos-15-intel" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: test (3.7, macos-15-intel)
  • GitHub Check: test (3.9, macos-latest)
  • GitHub Check: build (slurm)

Comment on lines 30 to +31
- python-version: "3.7"
platform: macos-13
platform: macos-15-intel
Copy link
Contributor

@coderabbitai coderabbitai bot Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Invalid runner label will block the workflow

macos-15-intel isn’t recognised by GitHub-hosted runners (actionlint flags it as unknown), so this job will stay queued forever. Please swap in a supported label (e.g., the official macos-15/size variant) or adjust the include strategy accordingly. Based on static analysis hints.


🌐 Web query:

List of all GitHub Actions hosted runner labels

💡 Result:

Here are the current GitHub-hosted runner labels (official documentation + runner-images repo):

  • Linux:

    • ubuntu-latest
    • ubuntu-24.04
    • ubuntu-22.04
  • Windows:

    • windows-latest
    • windows-2025
    • windows-2022
  • macOS:

    • macos-latest
    • macos-15
    • macos-15-large
    • macos-15-xlarge
    • macos-15-arm64 (listed as macOS 15 Arm64 / macos-15-arm64)
    • macos-14
    • macos-14-large
    • macos-14-xlarge
    • macos-14-arm64 (macOS 14 Arm64 / macos-14-xlarge variants)
    • macos-13
    • macos-13-large
    • macos-13-xlarge
    • macos-13-arm64 (macos-13-xlarge / macOS-13-arm64 variants)

Sources: official GitHub-hosted runners reference and the actions/runner-images repository. [1][2]

References
[1] GitHub Docs — GitHub-hosted runners reference.
[2] GitHub — actions/runner-images (labels → image table).


Invalid GitHub runner label
macos-15-intel isn’t a supported GitHub-hosted runner and will leave the job queued; replace it with a valid label such as macos-15, macos-15-large, or macos-15-xlarge.

🧰 Tools
🪛 actionlint (1.7.7)

31-31: label "macos-15-intel" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)

🤖 Prompt for AI Agents
In .github/workflows/test.yml around lines 30 to 31, the runner label
"macos-15-intel" is invalid and will leave the job queued; update the job’s
runner label to a supported GitHub-hosted runner such as "macos-15",
"macos-15-large", or "macos-15-xlarge" (remove the "-intel" suffix), ensuring
the new label matches the job matrix/constraints and retains the same
indentation/format in the YAML.

Copy link
Member Author

@njzjz njzjz Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a false positive.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧩 Analysis chain

🌐 Web query:

GitHub Actions macos-15-intel runner label October 2025

💡 Result:

Yes — as of October 2, 2025 GitHub Actions provides a macOS 15 Intel runner under the label macos-15-intel (for x86_64/Intel workloads). GitHub introduced that label for users needing an Intel environment and announced Intel/macOS deprecation timing (macOS 15 Intel images available until the announced retirement window ending in 2027). [1][2][3]

Sources:

  • GitHub-hosted runners reference (lists macos-15-intel). [1]
  • GitHub Changelog announcing the new macos-15-intel label and deprecation notice. [2]
  • actions/runner-images repo (runner image labels and macOS 15 availability). [3]

@njzjz You're absolutely right—my apologies for the incorrect flag. macos-15-intel is a valid GitHub-hosted runner label introduced in October 2025 for Intel/x86_64 workloads on macOS 15. The actionlint tool (v1.7.7) hasn't yet been updated to recognize this new label, which caused the false positive. Your PR change is correct. 👍


✏️ Learnings added
Learnt from: njzjz
PR: deepmodeling/dpdispatcher#551
File: .github/workflows/test.yml:30-31
Timestamp: 2025-10-02T19:22:48.620Z
Learning: The GitHub Actions runner label `macos-15-intel` is valid as of October 2, 2025. It provides macOS 15 on Intel/x86_64 architecture for workflows that require Intel CPUs instead of Apple Silicon ARM64.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

@njzjz njzjz merged commit fd51e42 into deepmodeling:master Oct 2, 2025
27 checks passed
@njzjz njzjz deleted the macos-15-intel branch October 2, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant