Skip to content

Conversation

@pluuc
Copy link
Contributor

@pluuc pluuc commented Sep 12, 2025

On fully localized systems, the Polkit authorization popup for libvirt still shows English text:

"Authentication is required to manage local virtualized systems"

This is because the message in org.libvirt.unix.policy is hardcoded in English and not wrapped with <_message> for translation.

I propose:

  1. Add <_message> support in the policy file (via .in template)
  2. Allow translations via the existing po/ infrastructure

This would greatly improve UX for non-English users.

Thanks!

@deepin-ci-robot
Copy link
Contributor

Hi @pluuc. Thanks for your PR. 😃

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tsic404 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Contributor

Hi @pluuc. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deepin-community-ci-bot
Copy link

TAG Bot

New tag: 10.7.0-3deepin2
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants