Skip to content

[Deepin-Kernel-SIG] [linux 6.6-y] [Upstream] Revert "cpuidle: menu: Avoid discarding useful information" #1311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: linux-6.6.y
Choose a base branch
from
+9 −12
Open

[Deepin-Kernel-SIG] [linux 6.6-y] [Upstream] Revert "cpuidle: menu: Avoid discarding useful information" #1311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions drivers/cpuidle/governors/menu.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,20 +230,17 @@ static unsigned int get_typical_interval(struct menu_device *data)
*
* This can deal with workloads that have long pauses interspersed
* with sporadic activity with a bunch of short pauses.
*
* However, if the number of remaining samples is too small to exclude
* any more outliers, allow the deepest available idle state to be
* selected because there are systems where the time spent by CPUs in
* deep idle states is correlated to the maximum frequency the CPUs
* can get to. On those systems, shallow idle states should be avoided
* unless there is a clear indication that the given CPU is most likley
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the comment: "likley" should be "likely".

Suggested change
* unless there is a clear indication that the given CPU is most likley
* unless there is a clear indication that the given CPU is most likely

Copilot uses AI. Check for mistakes.
* going to be woken up shortly.
*/
if (divisor * 4 <= INTERVALS * 3) {
/*
* If there are sufficiently many data points still under
* consideration after the outliers have been eliminated,
* returning without a prediction would be a mistake because it
* is likely that the next interval will not exceed the current
* maximum, so return the latter in that case.
*/
if (divisor >= INTERVALS / 2)
return max;

if (divisor * 4 <= INTERVALS * 3)
return UINT_MAX;
}

thresh = max - 1;
goto again;
Expand Down
Loading