Skip to content

Conversation

vbabich
Copy link
Collaborator

@vbabich vbabich commented Sep 30, 2025

  • Pass optional expandDescendants arg to setColumnExpanded
  • Pass mouse handlers and renderer from IrisGridPanel to IrisGrid

@vbabich vbabich self-assigned this Sep 30, 2025
@vbabich vbabich changed the title Pass optional expandDescendants arg to setColumnExpanded fix: Pass optional expandDescendants arg to setColumnExpanded Sep 30, 2025
@vbabich vbabich marked this pull request as ready for review September 30, 2025 22:20
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.95%. Comparing base (f7fe8ad) to head (017db92).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2540    +/-   ##
========================================
  Coverage   44.95%   44.95%            
========================================
  Files         765      765            
  Lines       42917    42920     +3     
  Branches    10796    10998   +202     
========================================
+ Hits        19293    19296     +3     
+ Misses      23611    23563    -48     
- Partials       13       61    +48     
Flag Coverage Δ
unit 44.95% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vbabich vbabich requested review from a team and bmingles and removed request for a team October 1, 2025 19:29
Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Left comment about 1 place you could use your new MouseHandlersProp type

@vbabich vbabich requested a review from bmingles October 2, 2025 19:48
@vbabich vbabich enabled auto-merge (squash) October 2, 2025 20:09
Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbabich vbabich merged commit a19bc11 into deephaven:main Oct 2, 2025
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2025
@vbabich vbabich deleted the pass_expand_descendants_arg branch October 2, 2025 20:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants