-
Notifications
You must be signed in to change notification settings - Fork 33
fix: Pass optional expandDescendants arg to setColumnExpanded #2540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2540 +/- ##
========================================
Coverage 44.95% 44.95%
========================================
Files 765 765
Lines 42917 42920 +3
Branches 10796 10998 +202
========================================
+ Hits 19293 19296 +3
+ Misses 23611 23563 -48
- Partials 13 61 +48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Left comment about 1 place you could use your new MouseHandlersProp
type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
expandDescendants
arg tosetColumnExpanded
IrisGridPanel
toIrisGrid