Skip to content

Conversation

bmingles
Copy link
Contributor

Attempt to lazy load Monaco. It is still eagerly loading monaco.js and monaco.css for some reason. Can't figure out why.

Copy link
Contributor

Pull Request titles must follow the Conventional Commits specification.

Details:

Unknown release type "Spike" found in pull request title "Spike: Lazy load Monaco (DH-20141)". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

).href
}
/>,
// <ConsolePlugin
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be re-enabled. I commented it out to rule out a source of eager loading Monaco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant