-
Notifications
You must be signed in to change notification settings - Fork 88
docs: DOC-655: Groovy SQL how-to & reference #7264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only two minor comments. Here's a larger comment, though:
This PR adds one user guide, named identically to the Python user guide. However, this Groovy page differs immensely from the Python page because the SQL integration is much more fleshed out in Groovy/Java.
I looked through the source code for the Python SQL integration and it appears that, unlike most of our Python API, it's not just Java wrapped in Python.
This comment is long and there may be nothing to actually do as a result of it, but the overarching comment is that in Python you can actually query databases like Postgres into DH tables. This guide only runs SQL queries against DH tables to get new DH tables. If you can do in Groovy what you can do in Python, we also need to document that.
docs/groovy/how-to-guides/data-import-export/execute-sql-queries.md
Outdated
Show resolved
Hide resolved
|
||
### Supported SQL features | ||
|
||
Deephaven's SQL implementation supports: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it better to list what you can do instead of what you can't do? The list below seems pretty comprehensive.
docs/groovy/how-to-guides/data-import-export/execute-sql-queries.md
Outdated
Show resolved
Hide resolved
docs/groovy/how-to-guides/data-import-export/execute-sql-queries.md
Outdated
Show resolved
Hide resolved
|
||
This is useful for: | ||
|
||
- Validating SQL syntax before execution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could use a little more information here. After reading this, I'm still not sure why anyone would use the dryRun method. I can validate my SQL context when I run evaluate(). What's the advantage of doing it with dryRun()? What does "Inspecting the query plan" mean? I'm not sure how this would help build tools that work with SQL queries either
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see further down you list "Fast validation without execution"- this seems like a good point to add here
https://deephaven.atlassian.net/jira/software/projects/DOC/boards/8?selectedIssue=DOC-655