fix: DH-20540: Ensure DataIndex pushdown is not short-circuited #7262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds some more structuring to BasePushdownFilterContext and ParquetTableLocation to make it more obvious what pushdown filter operations should be tried, and making sure we are only short-circuiting when no pushdown will be applied. Additonally, this ensures that the cost estimate and pushdown filtering occurs in cost-order.
No docs changes detected for b57f23b |
devinrsmith
added
NoDocumentationNeeded
NoReleaseNotesNeeded
lbooker42
reviewed
Oct 2, 2025
...ns/parquet/table/src/main/java/io/deephaven/parquet/table/location/ParquetTableLocation.java
Outdated
Show resolved
Hide resolved
lbooker42
approved these changes
Oct 3, 2025
|
|
||
| // --------------------------------------------------------------------------------------------------------------- | ||
|
|
||
| enum PushdownMode { |
There was a problem hiding this comment.
I suspect we'll need to abtract PushdownMode from the parquet-specific branches in the future. I imagine it would be useful for DHE storage pushdown, maybe even iceberg file-level metadata pushdown.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some more structuring to BasePushdownFilterContext and ParquetTableLocation to make it more obvious what pushdown filter operations should be tried, and making sure we are only short-circuiting when no pushdown will be applied.
Additonally, this ensures that the cost estimate and pushdown filtering occurs in cost-order.