(feat.) add notification apis phase I #2184
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramanan-ravi
reviewed
Jun 5, 2024
| var err error | ||
| for _, scanType := range scanTypes { | ||
| switch scanType { | ||
| case "vulnerability": |
There was a problem hiding this comment.
I think this can be simplified by having a map like this https://github.com/deepfence/ThreatMapper/blob/main/deepfence_utils/utils/constants.go#L137
There was a problem hiding this comment.
@ibreakthecloud Can you also check the lint errors?
There was a problem hiding this comment.
only possible changes where using constants, we cannot simplify this since each scan result has to go in different fields of struct.
I did the changes, please check again
gnmahanth
approved these changes
Jun 5, 2024
ibreakthecloud
force-pushed
the
feat-notification
branch
from
c221b01 to
a40c687
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Requires UI changes