Skip to content

Google Sheets #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
May 26, 2025
Merged

Google Sheets #1156

merged 29 commits into from
May 26, 2025

Conversation

stherzada
Copy link
Collaborator

What is this Contribution About?

Please provide a brief description of the changes or enhancements you are proposing in this pull request.

Issue Link

Please link to the relevant issue that this pull request addresses:

Loom Video

Record a quick screencast describing your changes to help the team understand and review your contribution. This will greatly assist in the review process.

Demonstration Link

Provide a link to a branch or environment where this pull request can be tested and seen in action.

Copy link
Contributor

Tagging Options

Should a new tag be published when this PR is merged?

  • 👍 for Patch 0.87.1 update
  • 🎉 for Minor 0.88.0 update
  • 🚀 for Major 1.0.0 update

viktormarinho and others added 14 commits May 21, 2025 22:12
…s type from unknown[][] to any[][] per Google API spec - Fix range pattern to accept single cells (A1) and ranges (A1:B10) - Remove unsupported @examples and @Schema annotations - Simplify value validation to match Google API requirements - Clean up documentation and remove redundant comments - Improve type safety with deno-lint-ignore for any types
… Create @types.ts with user-friendly simplified types - Add mappers.ts with bidirectional conversion utilities - Update updateValues and batchUpdateValues to use simplified interface - Add comprehensive validation and error handling - Improve documentation with Portuguese descriptions and examples - Types are now reusable across all Google Sheets actions
Copy link
Contributor

@viktormarinho viktormarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to me that client id/secret should be required, no?

- Remove incorrect @types.ts file placement

- Migrate all type definitions to utils/types.ts

- Create utils/rangeUtils.ts for reusable range manipulation functions

- Create utils/mappers.ts for API mapping utilities

- Translate all comments and JSDoc from Portuguese to English

- Clean up code by removing unnecessary comment separators

- Improve code organization with centralized utilities
- Simplify batchUpdateValues and updateValues props structure

- Replace complex range parameters with simple sheet_name + values

- Add automatic range calculation from data dimensions

- Implement first_cell_location parameter (defaults to A1)

- Add comprehensive validation with clear error messages

- Maintain backward compatibility while improving usability

- Focus on essential parameters for easier LLM integration
- Add CREATE_SPREADSHEET annotation to createSpreadsheet.ts

- Add OAUTH_CALLBACK annotation to oauth/callback.ts

- Improve action discoverability and organization

- Standardize semantic naming convention across actions
- Add GET_SPREADSHEET_VALUES annotation to getValues.ts

- Add GET_BATCH_SPREADSHEET_VALUES annotation to getBatchValues.ts

- Add GET_SPREADSHEET_METADATA annotation to getSpreadsheet.ts

- Add OAUTH_START annotation to oauth/start.ts

- Translate remaining Portuguese comments to English

- Improve loader discoverability and semantic organization
- Fix import order according to Deno formatting rules

- Apply consistent line length and spacing

- Improve code formatting for better readability

- Ensure all files follow Deno style conventions
- Make clientId and clientSecret non-optional in OAuthProvider interface

- Add fallback empty strings for clientId and clientSecret in mod.ts

- Ensure better type safety for OAuth configuration

- Fix potential runtime issues with undefined OAuth credentials
- Change clientId and clientSecret from optional to required fields

- Improve type safety for OAuth provider configuration

- Prevent runtime errors with undefined OAuth credentials
@JonasJesus42 JonasJesus42 merged commit a755bd5 into main May 26, 2025
1 check passed
@JonasJesus42 JonasJesus42 deleted the sheets branch May 26, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants