Fix(Website): Check if "src" is undefined before images optimization #1047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging OptionsShould a new tag be published when this PR is merged?
|
Comment on lines
+169
to
+172
| if (!props.src) { | ||
| console.error("Missing src. This image will NOT be rendered"); | ||
| return null; | ||
| } |
There was a problem hiding this comment.
I think we should return some div to find the section with the error:
<div data-identifier-error />
| @@ -166,6 +166,11 @@ const Image = forwardRef<HTMLImageElement, Props>((props, ref) => { | |||
| ); | |||
| } | |||
|
|
|||
| if (!props.src) { | |||
| console.error("Missing src. This image will NOT be rendered"); | |||
| return null; | |||
There was a problem hiding this comment.
Suggested change
| return null; | |
| return <div data-identifier-error />; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this Contribution About?
With this PR the Image component will no more break the entire section if src is not defined correctly.
I'm not happy yet on how we are handling it, now it only shows that are some Image somewhere in my codebase that will not be rendered and I have no clue on where it is. I've tried to use
console.traceandconsole.error(new Error(...))but the stack trace that I get is not enough to locate where this log is coming from.