fix(vmbda): consider ContainerDisk type in hot-plug validation

[yaroslavborbat]

Description

Extend disk hot-plug validation to include ContainerDisk volumes alongside PersistentVolumeClaim.
Added checks for ContainerDisk presence and its Hotpluggable flag.

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

• The code is covered by unit tests.
• e2e tests passed.
• Documentation updated according to the changes.
• Changes were tested in the Kubernetes cluster manually.

Changelog entries

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Enhance the disk hot-plug validation logic to treat ContainerDisk volumes similarly to PersistentVolumeClaims, ensuring both presence checks and hotpluggable flag checks cover ContainerDisks.

Class diagram for updated Volume hot-plug validation

classDiagram
class Volume {
  +string Name
  +PersistentVolumeClaim PersistentVolumeClaim
  +ContainerDisk ContainerDisk
}
class PersistentVolumeClaim {
  +bool Hotpluggable
}
class ContainerDisk {
  +bool Hotpluggable
}
Volume --> PersistentVolumeClaim
Volume --> ContainerDisk

Loading

Flow diagram for disk hot-plug validation logic update

flowchart TD
    A["Start hot-plug validation"] --> B["Find Volume by name"]
    B --> C{"Volume has PersistentVolumeClaim or ContainerDisk?"}
    C -- No --> D["Return error: no PVC or ContainerDisk reference"]
    C -- Yes --> E{"Hotpluggable flag is true on PVC or ContainerDisk?"}
    E -- No --> F["Return error: not a hot-plugged volume"]
    E -- Yes --> G["Allow hot-plug"]

Loading

File-Level Changes

Change	Details	Files
Include ContainerDisk in presence validation	Reject volumes missing both PVC and ContainerDisk references Update error message to mention container disk option	images/virtualization-artifact/pkg/controller/service/attachment_service.go
Extend hotpluggable flag check to ContainerDisk	Combine PVC and ContainerDisk hotpluggable flag checks Use unified error path when neither type is marked hot-pluggable	images/virtualization-artifact/pkg/controller/service/attachment_service.go

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deckhouse-BOaTswain]

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: cancelled.

[deckhouse-BOaTswain]

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.