Skip to content

Conversation

danilrwx
Copy link
Contributor

@danilrwx danilrwx commented Aug 22, 2025

Description

This PR adds a new linter for golangci-lint. This linter is responsible for import aliases.

Why do we need it, and what problem does it solve?

First and foremost, to maintain consistency. There is a list of aliases that we use always and everywhere, so it would be wise to check their correctness with a linter and protect developers from typos and errors.

What is the expected result?

New linter for all golangci-lint rulesets.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: ci
type: feature
summary: add alias linter for golangci-lint
impact_level: low

Signed-off-by: Daniil Antoshin <[email protected]>
@danilrwx danilrwx added this to the v0.25.0 milestone Aug 22, 2025
Signed-off-by: Daniil Antoshin <[email protected]>
Signed-off-by: Daniil Antoshin <[email protected]>
@danilrwx danilrwx marked this pull request as ready for review August 22, 2025 15:15
@danilrwx danilrwx added the e2e/run Run e2e test on cluster of PR author label Aug 22, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Aug 22, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Aug 22, 2025
@nevermarine nevermarine modified the milestones: v0.25.0, v0.26.0 Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants