Skip to content

Conversation

eofff
Copy link
Contributor

@eofff eofff commented Aug 18, 2025

Description

If first block device in spec of VirtualMachine is VirtualImage or ClusterVirtualImage, it must be iso. Added a webhook for this.

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vm
type: chore
summary: Check is first block device bootable.

@eofff eofff changed the title add hook first disk draft Aug 18, 2025
Signed-off-by: Valeriy Khorunzhin <[email protected]>
@eofff eofff force-pushed the feat/vm/disable-not-iso-image-as-first-disk branch from be99251 to c1cd483 Compare August 19, 2025 08:12
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Aug 19, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Aug 19, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: cancelled.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Aug 19, 2025
@eofff eofff force-pushed the feat/vm/disable-not-iso-image-as-first-disk branch from b2fd7e8 to df0efa8 Compare August 19, 2025 09:12
Signed-off-by: Valeriy Khorunzhin <[email protected]>
@eofff eofff force-pushed the feat/vm/disable-not-iso-image-as-first-disk branch from df0efa8 to ade91c8 Compare August 19, 2025 09:17
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Aug 19, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Aug 19, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Aug 19, 2025
Signed-off-by: Valeriy Khorunzhin <[email protected]>
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Aug 19, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Aug 19, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: success.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Aug 19, 2025
@eofff eofff changed the title first disk draft chore(vm): check is first block device bootable Aug 20, 2025
@eofff eofff added this to the v0.25.0 milestone Aug 20, 2025
@eofff eofff marked this pull request as ready for review August 20, 2025 08:04
@eofff eofff requested a review from diafour August 20, 2025 08:17
@diafour
Copy link
Member

diafour commented Aug 20, 2025

Using validation webhook seems a partial solution. CVI/VI may absent during VM creation, or not ready (in progress). Denying creation of VM with such CVI/VI may break e2e tests time to time. We need to wait for CVI/VI readiness in VM controller and then set message in BlockDevicesReady condition if the first block device has wrong type.

Signed-off-by: Valeriy Khorunzhin <[email protected]>
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Aug 22, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Aug 22, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Aug 22, 2025
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Aug 26, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Aug 26, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Aug 26, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Aug 26, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Aug 27, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Aug 27, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Aug 27, 2025
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Aug 27, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Aug 27, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Aug 27, 2025
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Aug 27, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Aug 27, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Aug 27, 2025
@nevermarine nevermarine modified the milestones: v0.25.0, v0.26.0 Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants