-
Notifications
You must be signed in to change notification settings - Fork 2
chore(vm): check is first block device bootable #1359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Valeriy Khorunzhin <[email protected]>
be99251
to
c1cd483
Compare
Workflow has started. The target step completed with status: cancelled. |
b2fd7e8
to
df0efa8
Compare
Signed-off-by: Valeriy Khorunzhin <[email protected]>
df0efa8
to
ade91c8
Compare
Workflow has started. The target step completed with status: failure. |
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Workflow has started. The target step completed with status: success. |
...irtualization-artifact/pkg/controller/vm/internal/validators/first_block_device_validator.go
Outdated
Show resolved
Hide resolved
...irtualization-artifact/pkg/controller/vm/internal/validators/first_block_device_validator.go
Outdated
Show resolved
Hide resolved
...irtualization-artifact/pkg/controller/vm/internal/validators/first_block_device_validator.go
Outdated
Show resolved
Hide resolved
Using validation webhook seems a partial solution. CVI/VI may absent during VM creation, or not ready (in progress). Denying creation of VM with such CVI/VI may break e2e tests time to time. We need to wait for CVI/VI readiness in VM controller and then set message in BlockDevicesReady condition if the first block device has wrong type. |
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Workflow has started. The target step completed with status: failure. |
Workflow has started. The target step completed with status: failure. |
Workflow has started. The target step completed with status: failure. |
Workflow has started. The target step completed with status: failure. |
Workflow has started. The target step completed with status: failure. |
Workflow has started. The target step completed with status: failure. |
Description
If first block device in spec of VirtualMachine is VirtualImage or ClusterVirtualImage, it must be iso. Added a webhook for this.
Why do we need it, and what problem does it solve?
What is the expected result?
Checklist
Changelog entries