Skip to content

Conversation

LopatinDmitr
Copy link
Contributor

@LopatinDmitr LopatinDmitr commented Aug 14, 2025

Description

This PR enhances the snapshot and restore functionality by including VirtualMachineMACAddress resources.

  • VirtualMachineMACAddress is now captured in snapshots.
  • During restore, VirtualMachineMACAddress resources are properly recreated to ensure network configuration consistency.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vm
type: feature
summary: "MAC address management for additional network interfaces has been added using the `VirtualMachineMACAddress` and `VirtualMachineMACAddressLease` resources."

@LopatinDmitr LopatinDmitr changed the base branch from main to feat/api/vmmac-and-vmmaclease August 14, 2025 16:47
@LopatinDmitr LopatinDmitr added this to the v0.25.0 milestone Aug 14, 2025
@LopatinDmitr LopatinDmitr force-pushed the feat/vm/add-mac-in-snapshots-and-restore branch 9 times, most recently from 0015810 to cd4d8ee Compare August 15, 2025 11:33
@LopatinDmitr LopatinDmitr marked this pull request as ready for review August 15, 2025 11:36
@LopatinDmitr LopatinDmitr added the e2e/run Run e2e test on cluster of PR author label Aug 15, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Aug 15, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

z9r5
z9r5 previously approved these changes Aug 15, 2025
@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Aug 15, 2025
@LopatinDmitr LopatinDmitr force-pushed the feat/vm/add-mac-in-snapshots-and-restore branch from cd4d8ee to f394c09 Compare August 18, 2025 08:10
@LopatinDmitr LopatinDmitr marked this pull request as draft August 18, 2025 11:44
@LopatinDmitr LopatinDmitr force-pushed the feat/api/vmmac-and-vmmaclease branch 6 times, most recently from a8cc1b0 to cc03b22 Compare August 18, 2025 14:42
@LopatinDmitr LopatinDmitr force-pushed the feat/vm/add-mac-in-snapshots-and-restore branch from c8cad8f to d96cbbd Compare August 25, 2025 15:00
@LopatinDmitr LopatinDmitr force-pushed the feat/api/vmmac-and-vmmaclease branch from 938c9a8 to 848c6f4 Compare August 26, 2025 05:58
@LopatinDmitr LopatinDmitr force-pushed the feat/vm/add-mac-in-snapshots-and-restore branch 3 times, most recently from 359fec4 to 6e8461c Compare August 26, 2025 06:06
@LopatinDmitr LopatinDmitr force-pushed the feat/api/vmmac-and-vmmaclease branch from 848c6f4 to b1db7ae Compare August 26, 2025 06:07
@LopatinDmitr LopatinDmitr force-pushed the feat/vm/add-mac-in-snapshots-and-restore branch 3 times, most recently from 9c78c48 to 2604434 Compare August 26, 2025 09:34
@LopatinDmitr LopatinDmitr force-pushed the feat/api/vmmac-and-vmmaclease branch from 3cc27d9 to b920f98 Compare August 26, 2025 10:39
@LopatinDmitr LopatinDmitr force-pushed the feat/vm/add-mac-in-snapshots-and-restore branch from 2604434 to c99eaf8 Compare August 26, 2025 10:40
Base automatically changed from feat/api/vmmac-and-vmmaclease to main August 26, 2025 12:47
@LopatinDmitr LopatinDmitr dismissed stale reviews from hardcoretime, danilrwx, and z9r5 August 26, 2025 12:47

The base branch was changed.

@z9r5 z9r5 requested a review from MargaretKozlova August 26, 2025 12:51
@LopatinDmitr LopatinDmitr force-pushed the feat/vm/add-mac-in-snapshots-and-restore branch from c99eaf8 to 29c1d01 Compare August 26, 2025 12:52
@MargaretKozlova MargaretKozlova requested review from prismagod and removed request for MargaretKozlova August 26, 2025 13:40
@LopatinDmitr LopatinDmitr force-pushed the feat/vm/add-mac-in-snapshots-and-restore branch from 29c1d01 to 0cf0dd0 Compare August 26, 2025 14:36
@LopatinDmitr LopatinDmitr merged commit f3bc31c into main Aug 26, 2025
26 of 27 checks passed
@LopatinDmitr LopatinDmitr deleted the feat/vm/add-mac-in-snapshots-and-restore branch August 26, 2025 21:16
nevermarine pushed a commit that referenced this pull request Aug 27, 2025
feat(vm): add snapshotting and restore mac addresses

This PR enhances the snapshot and restore functionality by including VirtualMachineMACAddress resources.

- VirtualMachineMACAddress is now captured in snapshots.
- During restore, VirtualMachineMACAddress resources are properly recreated to ensure network configuration consistency.

Signed-off-by: Dmitry Lopatin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants