Move to go webhooks #90
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
astef
requested changes
Jun 4, 2025
| tlscertificate.GenSelfSignedTLSHookConf{ | ||
| CN: "csi-nfs-scheduler-extender", | ||
| Namespace: ModuleNamespace, | ||
| TLSSecretName: "csi-nfs-scheduler-extender-https-certs", |
There was a problem hiding this comment.
Secret name in python code is scheduler-extender-https-certs
| @@ -0,0 +1,254 @@ | |||
| /* | |||
There was a problem hiding this comment.
Below code is a modified version of module-sdk, which was added to sds-replicated-volume, because we have several certificates with a common CA there. Since you have only one CA in your case, it should be enough to use what module-sdk already have, it will be much simpler.
- See
020-webhook-certsor https://github.com/deckhouse/sds-local-volume/blob/main/hooks/go/020-webhook-certs/webhook-certs.go as an example. - Remove
hooks/go/tls-certificate/
There was a problem hiding this comment.
Tried rewriting, caught Helm error
run helm install: check helm values: 3 errors occurred:
* csiNfs.internal.customSchedulerExtenderCert.crt is required
* csiNfs.internal.customSchedulerExtenderCert.key is required
* csiNfs.internal.customSchedulerExtenderCert.ca is required
My point here is to put certificate generaton via module sdk as a different task and bring it to a uniform format across all our relevant modules
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure webhooks are up-to-date, rewrite several python-based webhooks to golang
Why do we need it, and what problem does it solve?
What is the expected result?
Checklist