Adding 'parentNode' to parentElement Decoder to account for SVGs in IE11 #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'm not actively maintaining elm-dom anymore, though. Could I ask you to submit to @K-Adam, who /is/ maintaining his fork over at https://github.com/K-Adam/elm-dom? |
|
Hi John, Sorry for the late reply, I somehow missed the notification. I commented on the original issue Adam |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SVGs in IE11 do not have the
parentElementattribute. Instead they only have theparentNodeattribute. Therefore, trying to decode the position of an SVG in IE11 fails silently. By allowing the decoder to try for both attributes, the package can successfully decode the position of SVGs in IE11